Re: [PATCH] mfd: add bq2415x charger driver

From: Mark Brown
Date: Tue Dec 06 2011 - 06:25:35 EST


On Tue, Dec 06, 2011 at 08:25:49AM +0100, Pali Roh?r wrote:
> On Tuesday 06 December 2011 02:12:47 you wrote:

> > Also, I'm not familiar with the regulator interface, but it seems to
> > be meant for real regulators, which have consumers, and based on those
> > consumers's needs the real voltage changes. This battery charger on
> > the other hand doesn't have anything like that. There will be no
> > consumer, and some stuff like the weak battery voltage is not even
> > related to a voltage supply, but rather a threshold that can be
> > configured to change some behavior of the charger, but there's no
> > point in changing it dynamically (or maybe at all).

> If regulator interface is not good, I can change it to some sysfs interface.
> But bq2415x chip driver is not only rx51 specified, so it should handle all
> chip capabilities.

It's been used by a few charger drivers not for the voltage regulation
but for the current regulation interface - it does provide an
abstraction allowing the battery driver to vary the current going into
the battery independantly of the thing regulating that current. This
does depend on what control the charger offers, some are designed to be
more autonomous than others.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/