[PATCH] usb: gadget: renesas_usbhs: Use kcalloc instead of kzallocto allocate array

From: Thomas Meyer
Date: Mon Dec 05 2011 - 12:32:44 EST


The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
---

diff -u -p a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c
--- a/drivers/usb/renesas_usbhs/mod_host.c 2011-11-28 19:36:48.033448938 +0100
+++ b/drivers/usb/renesas_usbhs/mod_host.c 2011-11-28 20:04:59.954526908 +0100
@@ -1268,7 +1268,7 @@ int usbhs_mod_host_probe(struct usbhs_pr
return -ENOMEM;
}

- pipe_info = kzalloc(sizeof(*pipe_info) * pipe_size, GFP_KERNEL);
+ pipe_info = kcalloc(pipe_size, sizeof(*pipe_info), GFP_KERNEL);
if (!pipe_info) {
dev_err(dev, "Could not allocate pipe_info\n");
goto usbhs_mod_host_probe_err;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/