[PATCH] Btrfs: Use kcalloc instead of kzalloc to allocate array

From: Thomas Meyer
Date: Mon Dec 05 2011 - 12:32:14 EST


The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
---

diff -u -p a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
--- a/fs/btrfs/volumes.c 2011-11-28 19:36:48.113451068 +0100
+++ b/fs/btrfs/volumes.c 2011-11-28 19:48:10.374677247 +0100
@@ -2450,7 +2450,7 @@ static int __btrfs_alloc_chunk(struct bt
max_chunk_size = min(div_factor(fs_devices->total_rw_bytes, 1),
max_chunk_size);

- devices_info = kzalloc(sizeof(*devices_info) * fs_devices->rw_devices,
+ devices_info = kcalloc(fs_devices->rw_devices, sizeof(*devices_info),
GFP_NOFS);
if (!devices_info)
return -ENOMEM;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/