Re: [PATCH 1/4] dynamic_debug: consolidate repetitive struct _ddebugdescriptor definitions

[Bart Van Assche]

On Fri, Sep 9, 2011 at 6:02 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Thu, 2011-09-08 at 20:42 -0700, Andrew Morton wrote:
> > On Thu, 08 Sep 2011 19:13:16 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > On Thu, 2011-09-08 at 16:52 -0700, Andrew Morton wrote:
> > > > On Tue, 30 Aug 2011 14:28:41 -0400
> > > > Jason Baron <jbaron@xxxxxxxxxx> wrote:
> > > > > Replace the repetitive struct _ddebug descriptor definitions with
> > > > > a new DECLARE_DYNAMIC_DEBUG_META_DATA(name, fmt) macro.
> > > > > +#define DECLARE_DYNAMIC_DEBUG_METADATA(name, fmt) Â Â Â Â Â Â Â\
> > > > > + Â Â Â static struct _ddebug __used __aligned(8) Â Â Â Â Â Â Â \
> > > > > + Â Â Â __attribute__((section("__verbose"))) name = { Â Â Â Â Â\
> > > > > + Â Â Â Â Â Â Â .modname = KBUILD_MODNAME, Â Â Â Â Â Â Â Â Â Â Â\
> > > > > + Â Â Â Â Â Â Â .function = __func__, Â Â Â Â Â Â Â Â Â Â Â Â Â \
> > > > > + Â Â Â Â Â Â Â .filename = __FILE__, Â Â Â Â Â Â Â Â Â Â Â Â Â \
> > > > > + Â Â Â Â Â Â Â .format = (fmt), Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â\
> > > > > + Â Â Â Â Â Â Â .lineno = __LINE__, Â Â Â Â Â Â Â Â Â Â Â Â Â Â \
> > > > > + Â Â Â Â Â Â Â .flags = Â_DPRINTK_FLAGS_DEFAULT, Â Â Â Â Â Â Â \
> > > > > + Â Â Â Â Â Â Â .enabled = false, Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \
> > > > > + Â Â Â }
> > > > <anal>That macro implements a definition, not a declaration</anal>
> > > Andrew, that's not quite true
> > It's precisely true.
> Not according to the c99 standard section 6.7

Have you read that paragraph ? This is what I found in paragraph 6.7,
which confirms Andrews interpretation:

<quote>
A declaration speciïes the interpretation and attributes of a set of
identiïers. A deïnition of an identiïer is a declaration for that
identiïer that:
- for an object, causes storage to be reserved for that object;
- for a function, includes the function body;
- for an enumeration constant or typedef name, is the (only)
declaration of the identiïer.
</quote>

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/