Re: [PATCH 1/3] clockevents: Use an atomic RCU notifier forclockevents

[Thomas Gleixner]

On Tue, 6 Sep 2011, Andi Kleen wrote:

> > The idle code, at least the one in drivers/idle/intel_idle.c, does
> > _NOT_ call into that code at all when a reliable lapic timer is
> > available:
> 
> But the ACPI idle doesn't check that, so it still has a scalability problem.
> 
> Hmm ok so could add that check into acpi idle too I guess, but then ACPI
> idle doesn't normally know anything about CPUs.
> 
> > Either you are using different code or your machine does not have that
> > ARAT flag set.
> 
> The second test was using ACPI idle.

And as I said in that very same mail:

> > Same applies for drivers/acpi/processor_idle.c

lapic_timer_check_state()
{
       if (cpu_has(&cpu_data(pr->id), X86_FEATURE_ARAT))
                return;
....

WTF are you talking about? 

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/