Re: [PATCH 02/16] freezer: don't unnecessarily set PF_NOFREEZEexplicitly

[Gustavo Padovan]

Hi Tejun,

* Tejun Heo <tj@xxxxxxxxxx> [2011-08-19 16:16:08 +0200]:

> Some drivers set PF_NOFREEZE in their kthread functions which is
> completely unnecessary and racy - some part of freezer code doesn't
> consider cases where PF_NOFREEZE is set asynchronous to freezer
> operations.
> 
> In general, there's no reason to allow setting PF_NOFREEZE explicitly.
> Remove them and change the documentation to note that setting
> PF_NOFREEZE directly isn't allowed.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> Cc: "Gustavo F. Padovan" <padovan@xxxxxxxxxxxxxx>
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> Cc: wwang <wei_wang@xxxxxxxxxxxxxx>
> ---
>  Documentation/power/freezing-of-tasks.txt |    2 +-
>  drivers/bluetooth/btmrvl_main.c           |    2 --
>  drivers/mfd/twl4030-irq.c                 |    3 ---
>  drivers/mfd/twl6030-irq.c                 |    2 --
>  drivers/staging/rts_pstor/rtsx.c          |    2 --
>  5 files changed, 1 insertions(+), 10 deletions(-)

Acked-by: Gustavo F. Padovan <padovan@xxxxxxxxxxxxxx>

	Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/