Re: [RFC PATCH] request: teach the device more intelligent

[Jens Axboe]

On 2011-08-09 05:47, Kyungmin Park wrote:
> Hi Jens
> 
> Now eMMC device requires the upper layer information to improve the data
> performance and reliability.
> 
> . Context ID
> Using the context information, it can sort out the data internally and improve the performance.
> The main problem is that it's needed to define "What's the context". 
> Actually I expect cfq queue has own unique ID but it doesn't so decide to use the pid instead
> 
> . Data Tag
> Using the Data Tag (1-bit information), It writes the data at SLC area when it's hot data. So it can make the chip more reliable.
> First I expect the REQ_META but current ext4 doesn't pass the WRITE_META. only use the READ_META. so it needs to investigate it.
> 
> With these characteristics, it's helpful to teach the device. After some consideration. it's needed to pass out these information at request data structure.
> 
> Can you give your opinions and does it proper fields at requests?

You need this to work on all IO schedulers, not just cfq. And since
that's the case, there's no need to add this field since you can just
retrieve it if the driver asks for it. For CFQ, it could look like this:

static int cfq_foo(struct request *rq)
{
        struct cfq_queue *cfqq = rq->elevator_private[1];

        if (cfqq)
                return cfqq->pid;

        return -1;
}

As to the hot part, I think that would be better as just a request flag
like eg the meta flag.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/