Re: [PATCH] stop_machine: build unconditionally if SMP

From: Tejun Heo
Date: Sun Aug 07 2011 - 03:39:33 EST


Hello,

On Sat, Aug 06, 2011 at 04:38:37PM -0700, Andrew Morton wrote:
> The priority is unclear. It appears that the patch fixes a build error
> under sone circumstances in current mainline?

I don't think it would have triggered build error as there are dummy
functions which just calls the function on the local CPU, but it does
look pretty broken now. e.g. ia64 supports memory hotplug which
depends on stop machine but it would still be using dummy local
version, which can't be right.

Robin, is there an open bug report regarding this issue? I'm not sure
enough to suggest -stable but definitely mainline material.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/