Re: [PATCH] stop_machine: build unconditionally if SMP

From: Andrew Morton
Date: Sat Aug 06 2011 - 19:36:35 EST


On Sat, 6 Aug 2011 10:03:23 +0200 Tejun Heo <tj@xxxxxxxxxx> wrote:

> Hello,
>
> On Sat, Aug 06, 2011 at 12:31:13PM +0530, Rabin Vincent wrote:
> > stop_machine() is built for "(SMP && MODULE_UNLOAD) || HOTPLUG_CPU", but
> > is also used by the timekeeping code, the mm code, ftrace, and couple of
> > things in arch/*. Just build it if we're using SMP, like it's already
> > the case on x86.
> >
> > Cc: x86@xxxxxxxxxx
> > Cc: Tejun Heo <tj@xxxxxxxxxx>
> > Signed-off-by: Rabin Vincent <rabin@xxxxxx>
>
> Yeah, looks good to me.
>
> Acked-by: Tejun Heo <tj@xxxxxxxxxx>
>
> Andrew, can you please route this one?
>

Sure.

The priority is unclear. It appears that the patch fixes a build error
under sone circumstances in current mainline?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/