Re: [PATCH 3/8] staging: vme: make [alloc|free]_consistent bridgespecific

[Dan Carpenter]

On Mon, Aug 01, 2011 at 12:20:48PM +0200, Manohar Vanga wrote:
>  	if (bridge->parent == NULL) {
>  		printk(KERN_ERR "Dev entry NULL\n");

The user wouldn't know which driver is printing the error.

>  		return NULL;
>  	}
> -	pdev = container_of(bridge->parent, struct pci_dev, dev);
>  
> -	return pci_alloc_consistent(pdev, size, dma);
> +	if (bridge->alloc_consistent == NULL) {
> +		printk(KERN_ERR "alloc_consistent not supported by bridge\n");

Could probably be improved as well.

> +		return NULL;
> +	}
> +

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/