Re: [PATCH 2/8] staging: vme: allow explicit assignment of busnumbers

From: Dan Carpenter
Date: Mon Aug 01 2011 - 07:12:16 EST


On Mon, Aug 01, 2011 at 12:20:47PM +0200, Manohar Vanga wrote:
> -static int vme_alloc_bus_num(void)
> +/* call with vme_bus_num_mtx held */

Why move the lock outside the function?

> +static int __vme_alloc_bus_num(int bus_num)
> {

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/