Re: [PATCH 6/7] perf, x86: Example code for AMD IBS

[Robert Richter]

On 29.07.11 12:58:49, Peter Zijlstra wrote:
> On Thu, 2011-07-28 at 15:46 +0200, Robert Richter wrote:
> >  tools/perf/Documentation/examples/ibs.c    |  436 ++++++++++++++++++++++++++++
> 
> That really isn't the place for this..
> 
> Also, how similar is the Alpha PMU to AMD IBS?

Would you prefer

 tools/perf/Documentation/examples/x86/ibs.c

instead?

Actually I wasn't sure if this place is ok at all. But I wanted to
publish the code for reference and testing. There isn't somthing
similar already there, and the perf tool code is also not the best
place to implement such cpu specific features.

But putting it to the documentation is common practice for library
packages (e.g. libpapi and libpfm). If the example is not for the
given architecture it won't be added to the package documentation.
This example won't be installed at all. Even for very special features
an example is important since it is often not part of the generic
implementation.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/