Re: [PATCH] perf, x86: Add hw_watchdog_set_attr() in a sake ofnmi-watchdog on P4

[Cyrill Gorcunov]

On Tue, Jun 28, 2011 at 07:40:44PM +0400, Cyrill Gorcunov wrote:
> On Tue, Jun 28, 2011 at 05:32:27PM +0200, Stephane Eranian wrote:
> > On Tue, Jun 28, 2011 at 5:28 PM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
> > > On Tue, Jun 28, 2011 at 05:24:36PM +0200, Stephane Eranian wrote:
> > > ...
> > >> >
> > >> > Yeah, not the _best_ place. Not sure too where to put it, patches are welcome ;)
> > >> >
> > >> No matter what, this file has to remain in a file that's common to all arch.
> > >
> > > well, hard to say, Stephane, nmi-watchdog is x86 specific as far as I know.
> > >
> > Sorry I was talking about the weak function() not the file.
> > 
> 
> Yes, I get it ;) I mean that this __weak function is always called from x86 site
> and outside of CONFIG_HARDLOCKUP_DETECTOR doesn't make much sense that is why I
> placed it there in first place. Though it look somehow... maybe "strange"
> I would say, that's why I agreed with Don it's not the best place.
> 
> 	Cyrill

As Don just pointed me (it's a shame that I forget about sparc since I remember
someone, maybe even Don,  was already pointing me that nmi-watchdog
is NOT x86 only thing! :) So yes Stephane, you're of course right, this weak
definition better to live in common place. I think if decide to change its
place -- better in a separate patch.

	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/