Re: [PATCH] perf, x86: Add hw_watchdog_set_attr() in a sake ofnmi-watchdog on P4

[Stephane Eranian]

Cyril,

#ifdef CONFIG_HARDLOCKUP_DETECTOR
+void __weak hw_nmi_watchdog_set_attr(struct perf_event_attr *wd_attr) { }


The weak function has to remain inside the #ifdef. Remember it's just an
override in case you cannot using the generic cycle event. It is only needed
when you have the HARDLOCK detector, i.e., are using the PMU to detect
deadlocks.

I suspect P4 may be the only one so far which exhibited a problem there.


On Tue, Jun 28, 2011 at 5:46 PM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
> On Tue, Jun 28, 2011 at 07:44:22PM +0400, Cyrill Gorcunov wrote:
>> On Tue, Jun 28, 2011 at 11:37:31AM -0400, Don Zickus wrote:
>> > On Tue, Jun 28, 2011 at 07:28:27PM +0400, Cyrill Gorcunov wrote:
>> > > On Tue, Jun 28, 2011 at 05:24:36PM +0200, Stephane Eranian wrote:
>> > > ...
>> > > > >
>> > > > > Yeah, not the _best_ place. Not sure too where to put it, patches are welcome ;)
>> > > > >
>> > > > No matter what, this file has to remain in a file that's common to all arch.
>> > >
>> > > well, hard to say, Stephane, nmi-watchdog is x86 specific as far as I know.
>> >
>> > No, other arches have similar mechanisms. ÂActually I think sparc
>> > copied-n-pasted an old implementation of the nmi_watchdog on x86.
>>
>> Mind to point me where it lives?
>
> Indeed, at least SPARC has it as well. Thanks for clarification!
>
>>
>> >
>> > It is just all we hear about is the watchdog on x86.
>> >
>> > Cheers,
>> > Don
>>
>> Â Â Â Cyrill
>
> Â Â Â ÂCyrill
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/