Re: [PATCH v2] kconfig: autogenerated config_is_xxx macro
From: Jean-Christophe PLAGNIOL-VILLARD
Date: Fri May 13 2011 - 04:47:54 EST
On 10:30 Fri 13 May , Ingo Molnar wrote:
>
> * Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> wrote:
>
> > -#ifdef CONFIG_PCI_BIOS
> > - if (!rt->signature) {
> > + if (config_is_pci_bios() && !rt->signature) {
>
> Makes sense - but please name it in a more obvious way, such as:
>
> pci_bios_enabled()
the idea to generate the macro via Kconfig
so I propose config_is_pci_bios() and if it's a module
config_is_pci_bios_module()
if you have a better convention naming I'm fine to change it
maybe
config_pci_bios_enabled() / config_pci_bios_module_enabled
or
pci_bios_enabled() / pci_bios_module_enabled()
Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/