Re: [PATCH v2] kconfig: autogenerated config_is_xxx macro

From: Ingo Molnar
Date: Fri May 13 2011 - 04:30:36 EST



* Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> wrote:

> -#ifdef CONFIG_PCI_BIOS
> - if (!rt->signature) {
> + if (config_is_pci_bios() && !rt->signature) {

Makes sense - but please name it in a more obvious way, such as:

pci_bios_enabled()

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/