Re: [PATCH] net: mac80211: fix compilation warning

From: Jovi Zhang
Date: Sun Mar 06 2011 - 23:15:16 EST


On Sun, Mar 6, 2011 at 12:30 AM, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
> On 03/05/2011 07:52 AM, Jovi Zhang wrote:
>>
>> On Sat, Mar 5, 2011 at 8:31 PM, Ben Hutchings<bhutchings@xxxxxxxxxxxxxx>
>> Âwrote:
>>>
>>> On Wed, 2011-03-02 at 18:32 -0500, bookjovi@xxxxxxxxx wrote:
>>>>
>>>> From: Jovi Zhang<bookjovi@xxxxxxxxx>
>>>>
>>>> this commit fix compilation warning as following:
>>>> net/mac80211/tx.c:1753: warning: unused variable mppath
>>>
>>> [...]
>>>
>>> You clearly didn't try building this with CONFIG_MAC80211_MESH enabled.
>>>
>> Sorry, indeed, maybe should be like this:
>>
>> +#ifdef CONFIG_MAC80211_MESH
>> Â Â Â Âstruct mesh_path *mppath = NULL;
>> +#endif
>
> Linville likes "struct mesh_path *mppath __maybe_unused = NULL;" over the
> ifdef form.

That's better, Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/