Re: [Patch] Patch for bug 13547

[Randy Dunlap]

On Wed, 2 Mar 2011 14:28:51 -0500 Chen Liu wrote:

[adding linux-scsi]

> Hi everyone,
> 
> There is a patch generated by the tool R2Fix for bug 13547. Could you
> take a look at them? Thanks!
> The patch:
> --- linux-2.6.30/drivers/scsi/FlashPoint.c    2009-06-09
> 23:05:27.000000000 -0400
> +++ /tmp/cocci-output-726-34f8c9-FlashPoint.c    2011-02-23
> 22:05:29.765164083 -0500
> @@ -1212,7 +1212,7 @@ static unsigned long FlashPoint_Hardware
> 
>      ioport = pCardInfo->si_baseaddr;
> 
> -    for (thisCard = 0; thisCard <= MAX_CARDS; thisCard++) {
> +    for (thisCard = 0; thisCard < MAX_CARDS; thisCard++) {
> 
>          if (thisCard == MAX_CARDS) {


Please fix the R2Fix tool to generate patches correctly:
The +++ file name is incorrect.

The patch is whitespace-damaged.  gmail isn't good at preserving
tabs -- they have been converted to spaces, so the patch does not
apply cleanly.

If this patch is applied, how does this function return FAILURE?
I don't think that is does -- I think the patch is bad.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/