Re: [PATCH ref0] net: add Faraday FTMAC100 10/100 Ethernet driver

[Po-Yu Chuang]

Hi Eric,

On Sat, Feb 26, 2011 at 2:47 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> Le vendredi 25 fÃvrier 2011 Ã 19:45 +0100, Eric Dumazet a Ãcrit :
>> Le vendredi 25 fÃvrier 2011 Ã 10:34 -0800, David Miller a Ãcrit :
>> > From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
>> > Date: Fri, 25 Feb 2011 11:52:07 +0100
>> >
>> > > Le vendredi 25 fÃvrier 2011 Ã 17:45 +0800, Po-Yu Chuang a Ãcrit :
>> > >
>> > >> It's a little faster than v5 now. Thanks.
>> > >> I will submit the current version later.
>> > >>
>> > >> One more question just curious, why 128 bytes?
>> > >
>> > > Probably its best for NIU hardware specs
>> > >
>> > > You could try 64, as it should be enough for most IP/TCP/UDP processing.
>> >
>> > IPV6.
>>
>> drivers/net/benet/be.h:70:#define BE_HDR_LEN Â Â Â Â Â Â64
>>
>> Maybe we should have a comment somewhere.
>>
>> CC Ajit Khaparde <ajit.khaparde@xxxxxxxxxx>
>>
>
>
> A compromise would be to use 128 for the allocation, but only copy 64
> bytes.

I will use this way and submit v7 later.

Thanks,
Po-Yu Chuang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/