Re: [PATCH 1/1]mmc: fix division by zero when calculate mmc erase time

From: Linus Walleij
Date: Thu Feb 24 2011 - 07:35:50 EST


2011/2/24 Chuanxiao Dong <chuanxiao.dong@xxxxxxxxx>:
> Since if clock gating feature is enabled, the clock frequency may be zero when
> host clock is gated. In such scenario, mmc_set_mmc_erase_timeout() may have a
> division by zero bug.
>
> So this patch used mmc_host_clk_rate() to fix this.
>
> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@xxxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Actually I think these divide-by zero bugs were there before since clock
0 is perfectly legal, we just didn't trigger them before.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/