Re: linux-next: Tree for December 8(drivers/platform/x86/Kconfig:422:error: recursive dependency detected!)

From: Dmitry Torokhov
Date: Wed Dec 08 2010 - 18:31:15 EST


On Wed, Dec 08, 2010 at 11:08:39PM +0000, David Woodhouse wrote:
> On Wed, 2010-12-08 at 13:51 -0800, Randy Dunlap wrote:
> >
> > I dislike select, but reality is that modules do need to select/enable
> > library code and minor features sometimes.
> >
> > OTOH, where drivers/platform/x86/Kconfig:ACPI_CMPC does "select INPUT"
> > to enable an entire subsystem is wrong and bad IMO.
>
> This is just a deficiency in the tools. The correct answer is to fix the
> damn tools, not invent this silly 'select' facility which means much the
> same thing as 'depends on' but is implemented differently.
>
> As long ago as the mid-1990s, the Nemesis research OS was using a tcl
> xconfig tool based on the Linux one, but which would show you the
> dependencies for an option that was disabled, so you could enable them
> where you needed to. Rather than just hiding the option completely.

Even better tool would allow selecting the needed optios right there,
without the need of moving away from teh current option. And yet better
tool would not even ask user and enable them on its own. Hey, but we
have it! It's called "select".

Seriously, select is dangerous. I wonder if a rule like "One can only
select a symbol whose dependencies are all satisfied by the current
symbol and/or its parents and the symbols they select or depend on"
would not make select safe enough.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/