Re: [PATCH v1.5 5/5] keys: add new key-type encrypted

[David Howells]

Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:

> > > +static struct key *request_trusted_key(const char *trusted_desc,
> > > +				       u8 **master_key,
> > > +				       unsigned int *master_keylen)
> > 
> > You need to annotate the function with an __acquires() to indicate that it
> > returns with a lock held for Sparse checking.  I think you should be able to
> > do:
> > 
> > 	__acquires(tkey->sem)
> 
> hm, only after addding '__acquires' are there Sparse errors.

Leave it, then.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/