[RFC]block: change sort order of elv_dispatch_sort

From: Shaohua Li
Date: Wed Dec 08 2010 - 00:42:21 EST


Change the sort order a little bit. Makes requests with sector above boundary
in ascendant order, and requests with sector below boundary in descendant
order. The goal is we have less disk spindle move.
For example, boundary is 7, we add sector 8, 1, 9, 2, 3, 4, 10, 12, 5, 11, 6
In the original sort, the sorted list is:
8, 9, 10, 11, 12, 1, 2, 3, 4, 5, 6
the spindle move is 8->12->1->6, total movement is 12*2 sectors
with the new sort, the list is:
8, 9, 10, 11, 12, 6, 5, 4, 3, 2, 1
the spindle move is 8->12->6->1, total movement is 12*1.5 sectors

Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>

diff --git a/block/elevator.c b/block/elevator.c
index 2569512..1e01e49 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -443,12 +443,12 @@ void elv_dispatch_sort(struct request_queue *q, struct request *rq)
if (blk_rq_pos(rq) >= boundary) {
if (blk_rq_pos(pos) < boundary)
continue;
+ if (blk_rq_pos(rq) >= blk_rq_pos(pos))
+ break;
} else {
- if (blk_rq_pos(pos) >= boundary)
+ if (blk_rq_pos(rq) < blk_rq_pos(pos))
break;
}
- if (blk_rq_pos(rq) >= blk_rq_pos(pos))
- break;
}

list_add(&rq->queuelist, entry);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/