Re: [tip:perf/core] x86, nmi_watchdog: Remove the old nmi_watchdog

From: Don Zickus
Date: Thu Nov 18 2010 - 15:03:17 EST


On Thu, Nov 18, 2010 at 11:39:50AM -0800, Yinghai Lu wrote:
> >
> > Please update the kernel-parameters.txt accordingly.
> >
> > and you need to keep unknown_nmi_panic or else as early_param().
> >
> > Also any corresponding part like "nmi_watchdog=off" ?
> >
>
> also you have some other left-over...
>
> Documentation/kernel-parameters.txt: unknown_nmi_panic
> Documentation/kernel-parameters.txt: Set unknown_nmi_panic=1 early on boot.
> Documentation/sysctl/kernel.txt:- unknown_nmi_panic
> Documentation/sysctl/kernel.txt:unknown_nmi_panic:
> arch/x86/include/asm/nmi.h:extern int unknown_nmi_panic;
> arch/x86/kernel/apic/hw_nmi.c:int unknown_nmi_panic;
> kernel/sysctl_binary.c: { CTL_INT, KERN_UNKNOWN_NMI_PANIC, "unknown_nmi_panic" },
>
> may still have left for nmi_watchdog too.

Yes the first part of the patch left in stubs. The second piece should
clean up stuff like nmi_watchdog.

On the other side unknown_nmi_panic is actually going to be added back in
with another patch that re-arranges the default_do_nmi() call that I
posted in another patch series.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/