Re: [PATCH] Make swap accounting default behavior configurable v4

[Michal Hocko]

On Thu 18-11-10 17:53:34, KAMEZAWA Hiroyuki wrote:
> On Thu, 18 Nov 2010 17:46:54 +0900
> Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> wrote:
> 
> > On Thu, 18 Nov 2010 09:23:32 +0100
> > Michal Hocko <mhocko@xxxxxxx> wrote:
> > 
> > > On Wed 17-11-10 12:28:01, Daisuke Nishimura wrote:
> > > > On Tue, 16 Nov 2010 17:12:25 -0800
> > > > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
[...]
> > > > > Yes, we're stuck with the old one now.
> > > > > 
> > > > > But we should note that "foo=[0|1]" is superior to "foo" and "nofoo". 
> > > > > Even if we didn't initially intend to add "nofoo".
> > > > > 
> > > > I see.
> > > > 
> > > > Michal-san, could you update your patch to use "swapaccount=[1|0]" ?
> > > 
> > > I have noticed that Andrew has already taken the last version of the
> > > patch for -mm tree. Should I still rework it to change swapaccount to
> > > swapaccount=0|1 resp. true|false?
> > > 
> > It's usual to update a patch into more sophisticated one while it is in -mm tree.
> > So, I think you'd better to do it(btw, I prefer 0|1 to true|false.
> > Reading kernel-parameters.txt, 0|1 is more commonly used.).
> > 
> 
> I vote for 0|1

Changes since v3:
* add 0|1 parameter values handling

Changes since v2:
* put the new parameter description to the proper (alphabetically
* sorted)
  place in Documentation/kernel-parameters.txt
  
Changes since v1:
* do not remove noswapaccount parameter and add swapaccount parameter
* instead
* Documentation/kernel-parameters.txt updated)

---