Re: [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitializedmemory

[Alan Cox]

On Thu, 16 Sep 2010 12:52:40 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Thu, 2010-09-16 at 18:07 +0100, Alan Cox wrote:
> > ->tiocmget;
> > > >  
> > > > +	memset(&icount, 0, sizeof(struct serial_icounter_struct));
> > > > +
> > > 
> > > Move the above to after the spinlocks.
> > 
> > Why - its a local variable ?
> > 
> > Easier to write
> > 
> > 	struct serial_icounter_struct icount = { 0 };
> > 
> > though
> 
> True, but if we want to micro-optimize, moving it after the spinlocks
> means we do no zero initialization in the tiocmget == 0. Although gcc
> may be smart enough to realize that too.

If you want to micro-optimise it you can enumerate the cases that
tiocmget can be NULL in that driver..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/