Re: [PATCH 11/11] staging: ti dspbridge: enable driver building

[Greg KH]

On Wed, Jun 23, 2010 at 04:14:00PM +0300, Ohad Ben-Cohen wrote:
> From: Omar Ramirez Luna <omar.ramirez@xxxxxx>
> 
> Add Kconfig + Makefile for TI's DSP Bridge driver
> and expose it to the staging menu.
> 
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@xxxxxx>
> Signed-off-by: Kanigeri, Hari <h-kanigeri2@xxxxxx>
> Signed-off-by: Ameya Palande <ameya.palande@xxxxxxxxx>
> Signed-off-by: Guzman Lugo, Fernando <fernando.lugo@xxxxxx>
> Signed-off-by: Hebbar, Shivananda <x0hebbar@xxxxxx>
> Signed-off-by: Ramos Falcon, Ernesto <ernesto@xxxxxx>
> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
> Signed-off-by: Anna, Suman <s-anna@xxxxxx>
> Signed-off-by: Gupta, Ramesh <grgupta@xxxxxx>
> Signed-off-by: Gomez Castellanos, Ivan <ivan.gomez@xxxxxx>
> Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@xxxxxxxxx>
> Signed-off-by: Armando Uribe De Leon <x0095078@xxxxxx>
> Signed-off-by: Deepak Chitriki <deepak.chitriki@xxxxxx>
> Signed-off-by: Menon, Nishanth <nm@xxxxxx>
> Signed-off-by: Phil Carmody <ext-phil.2.carmody@xxxxxxxxx>
> Signed-off-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
> ---
>  drivers/staging/Kconfig              |    2 +
>  drivers/staging/Makefile             |    1 +
>  drivers/staging/tidspbridge/Kconfig  |   88 ++++++++++++++++++++++++++++++++++
>  drivers/staging/tidspbridge/Makefile |   34 +++++++++++++
>  4 files changed, 125 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/staging/tidspbridge/Kconfig
>  create mode 100644 drivers/staging/tidspbridge/Makefile
> 
> 
> diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
> index 3de4bca..c9e8215 100644
> --- a/drivers/staging/Kconfig
> +++ b/drivers/staging/Kconfig
> @@ -153,5 +153,9 @@ source "drivers/staging/easycap/Kconfig"
>  
>  source "drivers/staging/solo6x10/Kconfig"
>  
> +source "drivers/staging/tidspbridge/Kconfig"
> +
> +source "drivers/staging/tidspbridge/Kconfig"
> +
>  endif # !STAGING_EXCLUDE_BUILD
>  endif # STAGING
> diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> index b28d820..952b64e 100644
> --- a/drivers/staging/Makefile
> +++ b/drivers/staging/Makefile
> @@ -57,3 +57,4 @@ obj-$(CONFIG_TOUCHSCREEN_MRSTOUCH)	+= mrst-touchscreen/
>  obj-$(CONFIG_MSM_STAGING)	+= msm/
>  obj-$(CONFIG_EASYCAP)		+= easycap/
>  obj-$(CONFIG_SOLO6X10)		+= solo6x10/
> +obj-$(CONFIG_TIDSPBRIDGE)	+= tidspbridge/
> diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging/tidspbridge/Kconfig
> new file mode 100644
> index 0000000..37fa2b1
> --- /dev/null
> +++ b/drivers/staging/tidspbridge/Kconfig
> @@ -0,0 +1,88 @@
> +#
> +# DSP Bridge Driver Support
> +#
> +
> +menuconfig TIDSPBRIDGE
> +	tristate "DSP Bridge driver"
> +	default n

The default is always 'n' so you don't need this.

Also, this enables the driver to be built on x86, which fails horribly,
and I don't think is what you really want to have happen :)

So I need some more Kconfig changes here, care to redo just this one
patch?  I've applied all the others and they will show up in linux-next
tomorrow.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/