Re: [PATCH v4] panic: keep blinking in spite of long spin timer mode

[TAMUKI Shoichi]

Hello,

On Tue, 22 Jun 2010 13:16:54 -0700 Andrew Morton wrote:

> > To keep panic_timeout accuracy when running under a hypervisor, the
> > current implementation only spins on long time (1 second) calls to
> > mdelay.  That brings a good effect, but the problem is the keyboard
> > LEDs don't blink at all on that situation.
> > 
> > This patch changes to call to panic_blink_enter() between every mdelay
> > and keeps blinking in spite of long spin timer mode.
> > 
> > The time to call to mdelay is now 100ms.  Even this change will keep
> > panic_timeout accuracy enough when running under a hypervisor.
> 
> Thaks for sticking with it - I think the code's a lot better now.  Are
> you happy with it?

Oh, yes.  That's very thoughtful of you.

Regards,
TAMUKI Shoichi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/