Re: [PATCH V3 3/8] Cleancache: core ops functions and configuration

From: Christoph Hellwig
Date: Tue Jun 22 2010 - 10:43:39 EST


On Mon, Jun 21, 2010 at 04:19:39PM -0700, Dan Magenheimer wrote:
> [PATCH V3 3/8] Cleancache: core ops functions and configuration
>
> Cleancache core ops functions and configuration

NACK for code that just adds random hooks all over VFS and even
individual FS code, does an EXPORT_SYMBOL but doesn't actually introduce
any users.

And even if it had users these would have to be damn good ones given how
invasive it is. So what exactly is this going to help us? Given your
affiliation probably something Xen related, so some real use case would
be interesting as well instead of just making Xen suck slightly less.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/