Re: [PATCH] kbuild: Clean up and speed up the localversion logic

[Michal Marek]

On 22.6.2010 12:44, Nico Schottelius wrote:
> Michal Marek [Thu, Jun 17, 2010 at 03:40:38PM +0200]:
>> -cd "${1:-.}" || usage
>> +scm_only=false
>> +srctree=.
>> +if test "$1" = "--scm-only"; then
>> +	scm_only=true
>> +	shift
>> +fi
>> +if test $# -gt 0; then
>> +	srctree=$1
> 
> You probably want
> 
> srctree="$1" 
> 
> to catch spaces and co. in the path.

That's the same, the value in variable assignment is not subject to word
splitting.


> Otherwise I just had a quick view over it, but seems to look good.

Thanks!

/me is now wondering if it's ok to push this for 2.6.35. At least, there
were no bugreports from linux-next users so far.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/