Re: [RFC][PATCH 3/8] perf: register pmu implementations

[Peter Zijlstra]

On Fri, 2010-06-18 at 09:31 +1000, Paul Mackerras wrote:
> 
> > @@ -1011,7 +1001,7 @@ static int hw_perf_cache_event(u64 confi
> >       return 0;
> >  }
> >  
> > -struct pmu *hw_perf_event_init(struct perf_event *event)
> > +static int power_pmu_event_init(struct perf_event *event)
> 
> How does power_pmu_event_init ever get called now?  I don't see any
> other references to it in the patch.  Should struct pmu have a
> reference to it? 

Uhm yeah.. looks like that went pear-shaped. Fixed it.

---
Index: linux-2.6/arch/powerpc/kernel/perf_event.c
===================================================================
--- linux-2.6.orig/arch/powerpc/kernel/perf_event.c
+++ linux-2.6/arch/powerpc/kernel/perf_event.c
@@ -1125,6 +1125,7 @@ static int power_pmu_event_init(struct p
 }
 
 struct pmu power_pmu = {
+	.event_init	= power_pmu_event_init,
 	.enable		= power_pmu_enable,
 	.disable	= power_pmu_disable,
 	.read		= power_pmu_read,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/