Re: [RFC][PATCH 3/8] perf: register pmu implementations

[Paul Mackerras]

On Wed, Jun 16, 2010 at 06:00:30PM +0200, Peter Zijlstra wrote:

> Simple registration interface for struct pmu, this provides the
> infrastructure for removing all the weak functions.

Nice idea...

> @@ -1011,7 +1001,7 @@ static int hw_perf_cache_event(u64 confi
>  	return 0;
>  }
>  
> -struct pmu *hw_perf_event_init(struct perf_event *event)
> +static int power_pmu_event_init(struct perf_event *event)

How does power_pmu_event_init ever get called now?  I don't see any
other references to it in the patch.  Should struct pmu have a
reference to it?

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/