Re: hung bootup with "drm/radeon/kms: move radeon KMS on/off switchout of staging."

[david]

On Thu, 4 Feb 2010, Ingo Molnar wrote:

> * Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:
>
> > On Thu, 4 Feb 2010 20:32:32 +0100
> > Ingo Molnar <mingo@xxxxxxx> wrote:
> > > Nobody has reacted to my related boot hang bugreport yet - and it's
> > > detailed and fully reproducible (so i can test any proposed fixes as
> > > well in short order). I.e. my limited testing has triggered two
> > > separate bugs in the same driver - and this will show up in -rc7.
> > >
> > > It might be all OK and no-one else will see trouble. Or past patterns
> > > might repeat themselves and i might simply be an early bird for
> > > trouble to come.
> > >
> > > My (oft repeated) point is that adding new sub-features to existing
> > > drivers is not what we do in late -rc's: there's simply not enough
> > > time to shake out bugs/regressions in them.
> > >
> > > We introduce new functionality to existing drivers in the merge
> > > window - in the two weeks following a stable kernel's release.
> >
> > This is the .config issue right?  It doesn't sound like the bug is new,
> > you're just seeing now it because of the way you run tests.  It shouldn't
> > affect any more or fewer users than it did before, and reverting the "move
> > radeon KMS out of staging" won't fix the bug at all or prevent anyone from
> > seeing it.  People using KMS will still use KMS and people without it
> > won't, [...]
>
> I think you are missing my point. My point is very simple: existing non-KMS
> users of CONFIG_DRM_RADON=y (a pre-existing driver) might turn on the new
> sub-feature (CONFIG_DRM_RADEON_KMS=y), in the expectation that this is a safe
> addition to his currently well-working driver.
>
> ( I have to confess i do that all the time for drivers that work well for me,
>  and if it pops up in a late -rc i sure expect it to be safe to enable. I
>  dont even read the help text most of the time - if the single-line summary
>  sounds useful i enable it. Especially if the Kconfig help entry says it's
>  safe with a new distro, it's not CONFIG_EXPERIMENTAL, it's not marked
>  CONFIG_BROKEN, it's not in CONFIG_STAGING, etc. )

forget the people testing the rc kernels, what about people who will see 
this in the released kernel?

David Lang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/