Re: [PWM PATCH 3/5] Expunge old Atmel PWMC driver, replacing it withone that conforms to the PWM API

From: Bill Gatliff
Date: Tue Feb 02 2010 - 23:11:21 EST


H Hartley Sweeten wrote:
>
> You have a couple name changes here, were they intentional?
>
> Filename: atmel_pwm.c -> atmel-pwm.c
> Driver name: atmel_pwm -> atmel_pwmc
> Module alias: platform:atmel_pwm -> platform:atmel_pwmc
>
>

Yes. In the datasheet, the peripheral is called the "PWMC" and so
that's why the driver name changed. For consistency, I guess I should
have named the file atmel-pwmc.c as well. Finally, I find it easier to
type file names with dashes rather than underscores. :)

> Also, will this new driver still work for all the existing users of
> the old one? Are there any platform changes that need to be done?
>

There are platform changes necessary, to register and use the devices.
The driver API is different from the previous code, so there are changes
there as well. Functionally, however, the new stuff is a superset of
what the previous driver provided.


b.g.

--
Bill Gatliff
bgat@xxxxxxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/