RE: [PWM PATCH 3/5] Expunge old Atmel PWMC driver, replacing it with one that conforms to the PWM API

[H Hartley Sweeten]

On Tuesday, February 02, 2010 12:15 AM, Bill Gatliff wrote:
> Signed-off-by: Bill Gatliff <bgat@xxxxxxxxxxxxxxx>
> ---
>  drivers/misc/Makefile    |    6 +-
>  drivers/misc/atmel_pwm.c |  409 --------------------------------
>  drivers/pwm/atmel-pwm.c  |  589 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 594 insertions(+), 410 deletions(-)
>  delete mode 100644 drivers/misc/atmel_pwm.c
>  create mode 100644 drivers/pwm/atmel-pwm.c

A couple quick comments, more after a better review.

[snip]

> diff --git a/drivers/misc/atmel_pwm.c b/drivers/misc/atmel_pwm.c
> deleted file mode 100644
> index 6aa5294..0000000
> --- a/drivers/misc/atmel_pwm.c
> +++ /dev/null

[snip]

> -static struct platform_driver atmel_pwm_driver = {
> -	.driver = {
> -		.name = "atmel_pwm",
> -		.owner = THIS_MODULE,
> -	},

[snip]

> -MODULE_DESCRIPTION("Driver for AT32/AT91 PWM module");
> -MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:atmel_pwm");
> diff --git a/drivers/pwm/atmel-pwm.c b/drivers/pwm/atmel-pwm.c
> new file mode 100644
> index 0000000..a2a08c5
> --- /dev/null
> +++ b/drivers/pwm/atmel-pwm.c

[snip]

> +static struct platform_driver atmel_pwm_driver = {
> +	.driver = {
> +		.name = "atmel_pwmc",
> +		.owner = THIS_MODULE,
> +	},

[snip]

> +MODULE_AUTHOR("Bill Gatliff <bgat@xxxxxxxxxxxxxxx>");
> +MODULE_DESCRIPTION("Driver for Atmel PWMC peripheral");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:atmel_pwmc");

You have a couple name changes here, were they intentional?

    Filename: atmel_pwm.c        -> atmel-pwm.c
 Driver name: atmel_pwm          -> atmel_pwmc
Module alias: platform:atmel_pwm -> platform:atmel_pwmc

Also, will this new driver still work for all the existing users of
the old one?  Are there any platform changes that need to be done?

Regards,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/