Re: [PATCH] gianfar: Fix tests of unsigneds in gfar_parse_group()

[roel kluin]

On Wed, Dec 16, 2009 at 6:04 AM, Kumar Gopalpet-B05799
<B05799@xxxxxxxxxxxxx> wrote:
>
>>Won't it be better to change types of interruptTransmit,
>>-Receive and -Error in Âstruct gfar_priv_grp itself. Something
>>like this:

> struct gfar_priv_grp {
> ....
> - Â Â Â unsigned int interruptTransmit;
> - Â Â Â unsigned int interruptReceive;
> - Â Â Â unsigned int interruptError;
>
> + Â Â Â int interruptTransmit;
> + Â Â Â int interruptReceive;
> + Â Â Â int interruptError;
> ....
> }
>
> --
>
> Thanks
> Sandeep

I don't think that's better. Only the error returned is signed,
If none occurred the irq thereafter is unsigned.

Thanks,

Roel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/