RE: [PATCH] gianfar: Fix tests of unsigneds in gfar_parse_group()

[Kumar Gopalpet-B05799]

>Won't it be better to change types of interruptTransmit, 
>-Receive and -Error in  struct gfar_priv_grp itself. Something 
>like this:
>
>struct gfar_priv_grp {
>....
>-	unsigned int interruptTransmit;
>-	unsigned int interruptReceive;
>-	unsigned int interruptError;
>
>+	unsigned int interruptTransmit;
>+	unsigned int interruptReceive;
>+	unsigned int interruptError;
>....
>}
>

Sorry for my earlier mail, What I meant is something like this:

struct gfar_priv_grp {
....
-	unsigned int interruptTransmit;
-	unsigned int interruptReceive;
-	unsigned int interruptError;

+	int interruptTransmit;
+	int interruptReceive;
+	int interruptError;
....
}

--

Thanks
Sandeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/