Re: [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown?

From: Alan Cox
Date: Fri Oct 02 2009 - 07:49:33 EST


On Fri, 02 Oct 2009 19:37:21 +0900
lenrek@xxxxxx wrote:

> I found the counterpart of function mgslpc_wait_until_sent
> in drivers/char/synclinkmp.c (wait_until_sent) is modified to
> issue (un)lock_kernel. This patch does the same modification.
>
> However, I'm afraid similar modifications are necessary further on
> functions
> mgslpc_ioctl and mgslpc_write_room.

The push down work normally eliminated BKL calls that were demonstrably
not needed and left it in anywhere that needed thought. Do those
functions still really need the BKL ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/