[PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown?

From: lenrek
Date: Fri Oct 02 2009 - 07:41:51 EST


I found the counterpart of function mgslpc_wait_until_sent
in drivers/char/synclinkmp.c (wait_until_sent) is modified to
issue (un)lock_kernel. This patch does the same modification.

However, I'm afraid similar modifications are necessary further on functions
mgslpc_ioctl and mgslpc_write_room.



--- linux-2.6.31.1/drivers/char/pcmcia/synclink_cs.c 2009-10-02 17:01:23.000000000 +0900
+++ linux/drivers/char/pcmcia/synclink_cs.c 2009-10-02 17:23:59.000000000 +0900
@@ -2442,6 +2442,8 @@
if (!info )
return;

+ lock_kernel();
+
if (debug_level >= DEBUG_LEVEL_INFO)
printk("%s(%d):mgslpc_wait_until_sent(%s) entry\n",
__FILE__,__LINE__, info->device_name );
@@ -2490,6 +2492,7 @@
}

exit:
+ unlock_kernel();
if (debug_level >= DEBUG_LEVEL_INFO)
printk("%s(%d):mgslpc_wait_until_sent(%s) exit\n",
__FILE__,__LINE__, info->device_name );

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/