Re: [origin tree boot hang] [PATCH] Revert "early_printk:Allowmorethanone early console"

[Jason Wessel]

This is a multi-part message in MIME format.Linus Torvalds wrote:
> On Wed, 23 Sep 2009, Jason Wessel wrote:
>   
>> Perhaps you will consider adding this patch to your tree?   It fixes the
>> specific case you mentioned.  It will still allow the board to boot and
>> instead of crashing, print a warning on the second instance.
>>     
>
> Ugh. This looks totally bogus.
>
> Why don't you just add CON_REGISTERED to the console flags, and do
>
> 	/* Already registered? */
> 	if (early_console->flags & CON_REGISTERED)
> 		return;
> 	early_console->flags |= CON_REGISTERED;
>
> there instead? That whole "loop over existing consoles to check their 
> names" looks silly and broken, and you're already playing with the flags 
> in there (CON_BOOT).
>   

Seems reasonable to me.  We don't even have to add a new flag, because
we already have the index set to != -1 when the console registration
succeeds.

Here is the revised patch.

Jason.