Re: Hibernation oops with 2.6.31 won't fit the screen - bisected

From: Ondrej Zary
Date: Tue Sep 22 2009 - 15:56:33 EST


On Saturday 19 September 2009 23:44:54 Frans Pop wrote:
> Ondrej Zary wrote:
> > hibernation worked great with 2.6.30 - I had over a month of uptime (it
> > never worked so well before - always crashed after some time). But in
> > 2.6.31, it's broken again - and completely. The first hibernation works
> > but it always crashes on the second one.
> >
> > The problem is that the oops is so long that it does not fit the screen -
> > even 1280x1024 is not enough. Scrolling does not work (as it used to do
> > on 2.4 kernels), netconsole does not catch it. So how can I debug this?
>
> One way to get at least an indication of what broke the hibernation is to
> run a bisection to find the change that broke hibernation. That could
> provide sufficient clues for a next step.
>
> Would that be an option for you?

I bisected it and found this:

c7121843685de2bf7f3afd3ae1d6a146010bf1fc is first bad commit
commit c7121843685de2bf7f3afd3ae1d6a146010bf1fc
Author: Magnus Damm <magnus.damm@xxxxxxxxx>
Date: Tue Jul 28 14:09:55 2009 -0700

clocksource: Save mult_orig in clocksource_disable()

To fix the common case where ->enable() does not set up
mult, make sure mult_orig is saved in mult on disable.

Also add comments to explain why we do this.

Signed-off-by: Magnus Damm <damm@xxxxxxxxxx>
Cc: johnstul@xxxxxxxxxx
Cc: lethal@xxxxxxxxxxxx
Cc: akpm@xxxxxxxxxxxxxxxxxxxx
LKML-Reference: <20090618152432.10136.9932.sendpatchset@xxxxxxxxxxxxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

:040000 040000 c965062bc79af46cdb3522fc7ab1cc81d2f84de3 26616c88a8128b25fd15c3da39ac6251cd9723b6 M include


Reverting this commit fixes the problem.

--
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/