Re: [PATCH] make refrigerator cold

From: Rafael J. Wysocki
Date: Tue Sep 22 2009 - 15:52:56 EST


On Tuesday 22 September 2009, Stephen Hemminger wrote:
> By marking it cold, then the code path in kernel thread
> usage of try_to_freeze() that is normally used be
> selected.

The sentence above isn't very clear IMO, could you please rephrase?

> Don't think it matters that much for performance but the
> concordance of this patch struck me as humorous.

Well, yeah.

> Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
>
>
> --- a/include/linux/freezer.h 2009-09-21 20:34:17.579233461 -0700
> +++ b/include/linux/freezer.h 2009-09-21 20:35:25.724322028 -0700
> @@ -47,7 +47,7 @@ static inline bool should_send_signal(st
> /* Takes and releases task alloc lock using task_lock() */
> extern int thaw_process(struct task_struct *p);
>
> -extern void refrigerator(void);
> +extern void refrigerator(void) __cold;
> extern int freeze_processes(void);
> extern void thaw_processes(void);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/