Re: [PATCH] task_struct: stack_canary is not needed without CC_STACKPROTECTOR

[Andi Kleen]

Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx> writes:

> From: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
>
> The field stack_canary is only used with CC_STACKPROTECTOR.
> This patch reduces task_struct size without CC_STACKPROTECTOR.

Adding a ifdef in the middle of a widely used structure is nasty.  It
means that if someone changes the option then the newly loaded modules
don't work anymore (yes that's not officially supported, but works
most of the time and is often convenient in practice)

So when you add a ifdef please move the field to the end at least.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/