Re: [RFC patch] clean up swiotlb check in intel_iommu_init

[Luming Yu]

>>
>> Since swiotlb is an fall back option that might have
>> initialized. We don't need to stop intel_iommu_init
>> because of swiotlb..
>
> I think that this doesn't work on X86; breaks "soft" boot option.

Assumption is that swiotlb is default dma_ops.
I got this patch when working on ia64, will check x86 later.
But it is only needed when most of us agree that swiotlb should be
the default.

>
>
>> Please review. If make sense, please apply.
>>
>> **The patch is enclosed in text attachment*
>> **Using web client to send the patch* *
>> **below is for review, please apply attached Âpatch*/
>>
>> Thanks,
>> Luming
>>
>> Signed-off-by: Yu Luming <luming.yu@xxxxxxxxx>
>>
>> Âintel-iommu.c | Â Â2 +-
>> Â1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
>> index 2314ad7..246acb9 100644
>> --- a/drivers/pci/intel-iommu.c
>> +++ b/drivers/pci/intel-iommu.c
>> @@ -3194,7 +3194,7 @@ int __init intel_iommu_init(void)
>> Â Â Â Â* Check the need for DMA-remapping initialization now.
>> Â Â Â Â* Above initialization will also be used by Interrupt-remapping.
>> Â Â Â Â*/
>> - Â Â if (no_iommu || (swiotlb && !iommu_pass_through) || dmar_disabled)
>> + Â Â if (no_iommu || dmar_disabled)
>> Â Â Â Â Â Â Â return -ENODEV;
>>
>> Â Â Â iommu_init_mempool();
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/