Re: MMC: Make the configuration memory resource optional

From: Ian Molton
Date: Thu Jul 30 2009 - 15:21:26 EST


Guennadi Liakhovetski wrote:

While you're at it, please, consider swapping the two lines in tmio_mmc_probe():

- tmio_mmc_clk_stop(host);
reset(host);
+ tmio_mmc_clk_stop(host);

Otherwise, I think, reset causes problems trying to access the controller with disabled clock. At least this is needed on SuperH.

Interesting. I'll see what the result of this is on TMIO - This sequence was garnered from the WinCE driver for the chip.

I cant see _why_ this should be a problem, as this disables the card clock, not HCLK. Could you debug further in tmio_mmc_clk_stop() please and see if reordering only one of the two IO accesses cures this?

Let me know what you find out.

-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/