Re: [patch 3/5] Apply the PG_sensitive flag to audit subsystem

[Larry H.]

On 10:21 Sat 30 May     , Linus Torvalds wrote:
> 
> 
> On Wed, 20 May 2009, Larry H. wrote:
> >
> > +	if (!(gfp_mask & GFP_SENSITIVE))
> > +		gfp_mask |= GFP_SENSITIVE;
> 
> WTF?

Indeed.

> Why is this different from just "gfp_mask |= GFP_SENSITIVE;"

Blame anal retentiveness at the time of writing that. Surely the test
should be ditched. Looking back at that, I honestly think there might be a
place to plug the flag (in the caller) instead of doing that. I don't
think there are many places to do it, so this particular patch from the
set can be ditched and rewritten (if you want to take the selective
clearing road...)

	Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/