Re: [PATCH 1/5] MFD,mmc: tmio_mmc: make HCLK configurable

From: pHilipp Zabel
Date: Sat May 30 2009 - 07:40:57 EST


On Sat, May 30, 2009 at 11:59 AM, Ian molton <spyro@xxxxxxx> wrote:
>
> Acked-by: Ian Molton <spyro@xxxxxxx>

Thanks.

> However I'd like to see the clk API  weaned of its CPU spcific dependencies
> so that it can be used for this purpose instead.

Yes, I'm right with you on that.

> I consider ASIC3 support in this driver more important and this change is
> pretty noninvasive. Converting to the clk api in future shouldnt be any
> harder with this patch (actually slightly easier).

I'll try to add ASIC3 clock support in a way that it'll be easy to
convert to a architecture-independent struct clk in the future.

regards
Philipp

> Philipp Zabel wrote:
>>
>> The Toshiba parts all have a 24 MHz HCLK, but HTC ASIC3 has a 24.576 MHz
>> HCLK
>> and AMD Imageon w228x's HCLK is 80 MHz. With this patch, the MFD driver
>> provides the HCLK frequency to tmio_mmc via mfd_cell->driver_data.
>>
>> Signed-off-by: Philipp Zabel <philipp.zabel@xxxxxxxxx>
>> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxx>
>> Cc: Pierre Ossman <pierre@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/