Re: [tip:x86/mce3] x86, mce: trivial clean up for mce_intel_64.c

From: H. Peter Anvin
Date: Fri May 29 2009 - 16:19:51 EST


Andi Kleen wrote:
>> x86, mce: trivial clean up for mce_intel_64.c
>>
>> Fix for:
>>
>> WARNING: space prohibited between function name and open parenthesis '('
>> + for_each_online_cpu (cpu) {
>
> Sorry but that's just a bogus change. That's a loop and we always
> put spaces between the loop keyword and its condition.
>
> Just because checkpatch.pl is too dumb to understand that is no
> reason to make the code worse like that.
>

Look at EVERY OTHER for_each_online_cpu in the kernel.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/