Re: [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace_cxt

From: Roland McGrath
Date: Fri May 29 2009 - 16:19:26 EST


> > 5/12 still needs a comment about its assumption that tracehook_init_task()
> > allocated the struct iff appropriate.
>
> Not sure I understand... Where should I put this comment?

ptrace_init_task, to explain this line:

- if (unlikely(ptrace)) {
+ if (unlikely(child->ptrace_ctx)) {

> OK, will redo and resend. Perhaps I should send this series to you
> privately? I don't like to flood lkml again, the changes are cosmetic.

:-) Whatever you like. They will surely be posted at least twice more
before they get merged either way. The idea that any actual useful patches
might pollute the purity of the lkml stream is amusing. (Post them twice,
it will nudge up the signal-to-noise ratio. ;-)


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/