Re: linux-next: manual merge of the vfs tree with the tree

From: Frederic Weisbecker
Date: Mon May 25 2009 - 13:11:20 EST


On Mon, May 25, 2009 at 12:07:47AM +0200, Christoph Hellwig wrote:
> On Mon, May 25, 2009 at 12:03:38AM +0200, Frederic Weisbecker wrote:
> > > + if (s->s_dirt)
> > > + reiserfs_write_super(s);
> >
> >
> >
> > But this part seems to solve another conflict, right?
> > I'm not sure about it.
>
> Yes, different one. Previously the VFS called ->write_super just before
> ->put_super. Now any left over writeback needs to be dealt with by
> the filesystem. For now I have added a call to the write_super method
> to all filesystems, but most likely this can be removed later after
> an audit by someone who knows the filesystem.
>

Ok. Thanks for the clarification. So Stephen's fix seems to be
correct.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/